(Update) PHP8 Support #68
Conversation
|
Nice, I don't actually have any say in this package (I'm just a past contributor). But probably seems fine. Might be worth updating the CI workflows as well to run against PHP 8. 👍🏻 If you need any help with that, let me know. |
Co-authored-by: Owen Voke <development@voke.dev>
|
@owenvoke thanks. Updated the PHPUnit configs and the composer.json with your suggestion. |
|
Thanks for the PR, the code looks good. However some tests are failing due to some deprecation. Can you have a look? |
|
Looks like the depreciations are due to versions of Mockery lower than 1.4.1. 🤔 When running on the |
I have update tests and composer.json but IMO for them to all pass will need to drop PHP 7.2 support and only allow 7.3, 7.4 and 8.0. |
|
@Elhebert all tests are now passing. Would mean the new release oof this package would require PHP 7.3+ |
|
I feel like that's probably fine. PHP 7.2 is EOL, and people can still use the existing version perfectly fine if they are on 7.2. 🤔 |
|
Do we still need to |
Yes for PHP8. New release of this package should be v3.0.0 and requires PHP 7.3+ |
|
I already started work on a v3 (#57) which drop the support of Laravel 7 (and PHP 7.2.5). I'm going to merge (soon) #62 and #65 into master. Once this is done, you can rebase and see if we still need to have I'll try to do it before the end of the day (in the next 6-8 hours). That way we can release v3 with PHP8 support. |
|
If it's Laravel 8+, that should be fine. 👍🏻 |
|
@HDVinnie just merged both branches. You can now rebase on master ;) |
- force latest mockery for PHP8
|
@Elhebert PR is good to go. |
|
Should be able to just do |
| @@ -13,12 +13,13 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.3", | |||
| "php": "^7.3 | ^7.4 | ^8.0", | |||
There was a problem hiding this comment.
| "php": "^7.3 | ^7.4 | ^8.0", | |
| "php": "^7.3 || ^8.0", |
There was a problem hiding this comment.
This does the same thing.....just comes down to personal preference. I always like clearly defining each version. If you dont then ill change it.
|
v3 has been tagged and released 🎉 |
* (Update) PHP8 Support (#68) * update: php8 support * update: composer.json Co-authored-by: Owen Voke <development@voke.dev> * update: phpunit-l7.yml * update: phpunit-l8.yml * update: phpunit-l7.yml * update: phpunit-l8.yml * update: composer.json * update: composer.json * update: phpunit-l7.yml * update: composer.json * update: composer.json - force latest mockery for PHP8 Co-authored-by: Owen Voke <development@voke.dev> (cherry picked from commit cb60519) * (Update) PHP8 Support (#68) * update: php8 support * update: composer.json Co-authored-by: Owen Voke <development@voke.dev> * update: phpunit-l7.yml * update: phpunit-l8.yml * update: phpunit-l7.yml * update: phpunit-l8.yml * update: composer.json * update: composer.json * update: phpunit-l7.yml * update: composer.json * update: composer.json - force latest mockery for PHP8 Co-authored-by: Owen Voke <development@voke.dev> (cherry picked from commit cb60519) * Adjusted github actions. * Adjusted minimum versions of laravel 6 and 7. * Minimum version of mockery set. * Min. mockery only on php 8 build? Co-authored-by: HDVinnie <hdinnovations@protonmail.com> Co-authored-by: Thomas A. Hirsch <thomas.hirsch@vema-eg.de>
No description provided.