Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix : use appropriate tags for css and js #58

Merged

Conversation

juliomotol
Copy link
Contributor

URGENT!

laravel-sri/src/Sri.php

Lines 89 to 95 in 1e5e121

if (Str::endsWith($path, 'css')) {
return "<script src='{$href}' {$integrity} {$attributes}></script>";
} elseif (Str::endsWith($path, 'js')) {
return "<link href='{$href}' rel='stylesheet' {$integrity} {$attributes}>";
} else {
throw new \Exception('Invalid file');
}

I didn't notice that I used script tag for css and link tag for js.

This PR aims to resolve this problem

P.S. I'm really sorry 😢

@Elhebert Elhebert merged commit 606477a into Elhebert:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants