Link: add link component #15052
Merged
Link: add link component #15052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit 1b5c236 |
|
原生属性我觉得还是应该传递一下。 click 事件要不要 preventDefault ？ isHover 纯 css 就可以。 如果作为统一风格 / 替代原生 |
ziyoung
reviewed
Apr 18, 2019
test/unit/specs/link.spec.js
Outdated
| }, true); | ||
| vm.$el.click(); | ||
|
|
||
| setTimeout(_ => { |
packages/link/src/main.vue
Outdated
| <template v-if="$slots.icon"><slot v-if="$slots.icon" name="icon"></slot></template> | ||
|
|
||
| <!-- underline --> | ||
| <div |
|
review 都已经修改， functional component 讨论下来暂时先不做 看看用户反馈 |
FAKER-A
pushed a commit
to FAKER-A/element
that referenced
this pull request
May 7, 2019
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
预览地址 https://deploy-preview-15052--element.netlify.com/#/zh-CN/component/link
等中文文档 review 之后 再翻译英文文档
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.