Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert: Add dark theme #15041

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Conversation

island205
Copy link
Contributor

@island205 island205 commented Apr 10, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

element-bot commented Apr 10, 2019

Deploy preview for element ready!

Built with commit 8d519ca

https://deploy-preview-15041--element.netlify.com

@island205 island205 added this to the 2.8.0 milestone Apr 10, 2019
@iamkun iamkun self-requested a review April 10, 2019 06:35
Copy link
Member

@iamkun iamkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/docs/es/alert.md Outdated Show resolved Hide resolved
@island205 island205 force-pushed the feature/dark-theme-for-alert branch from ec8fd11 to ba65227 Compare April 10, 2019 12:19
@island205 island205 changed the title Alert: Add dark theme [WIP]Alert: Add dark theme Apr 10, 2019
@island205 island205 force-pushed the feature/dark-theme-for-alert branch 2 times, most recently from f84ff0c to 589e5d7 Compare April 12, 2019 05:59
@island205 island205 added the kiwi label Apr 12, 2019
@island205 island205 force-pushed the feature/dark-theme-for-alert branch 2 times, most recently from d4efe29 to c487672 Compare April 12, 2019 09:41
@ziyoung
Copy link
Contributor

ziyoung commented Apr 18, 2019

添加新属性:effect,默认值为 light。

@island205 island205 force-pushed the feature/dark-theme-for-alert branch from c487672 to 20a016e Compare April 18, 2019 08:59
@island205 island205 changed the title [WIP]Alert: Add dark theme Alert: Add dark theme Apr 18, 2019
@island205 island205 force-pushed the feature/dark-theme-for-alert branch from 20a016e to 2837a53 Compare April 18, 2019 09:07
types/alert.d.ts Outdated Show resolved Hide resolved
@ziyoung ziyoung merged commit 6865956 into ElemeFE:dev Apr 19, 2019
@ziyoung ziyoung mentioned this pull request Apr 19, 2019
3 tasks
FAKER-A pushed a commit to FAKER-A/element that referenced this pull request May 7, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants