Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascader: remove unnecessary DOM operation #14788

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Conversation

ziyoung
Copy link
Contributor

@ziyoung ziyoung commented Mar 21, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

修复文字重叠问题:https://codepen.io/ziyoung/pen/wOYbGe

相关 pr #14572

@element-bot
Copy link
Member

element-bot commented Mar 21, 2019

Deploy preview for element ready!

Built with commit 20889e0

https://deploy-preview-14788--element.netlify.com

@iamkun
Copy link
Member

iamkun commented Mar 21, 2019

LGTM

@ziyoung
Copy link
Contributor Author

ziyoung commented Mar 21, 2019

稍后再补充一个测试。

Copy link
Contributor

@island205 island205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziyoung ziyoung merged commit d956022 into ElemeFE:dev Mar 21, 2019
@ziyoung ziyoung deleted the cascader-bug branch March 21, 2019 10:11
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
* Cascader: remove unnecessary DOM operation

* update cascader test
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
* Cascader: remove unnecessary DOM operation

* update cascader test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants