Table: fix the bug setting default-sort to Table triggers sort-change… #14625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit d0164d5 |
|
Any news on this please? |
ziyoung
reviewed
Apr 17, 2019
|
@PeanutWatson 修改一下。另外这个属性 |
好滴，多谢指教，我修改一下。 |
added 3 commits
April 20, 2019 23:34
…directly Last commit failed by trailing spaces, fix it.
…directly (ElemeFE#13750) Change the code according the reviewer advises.
|
@ziyoung 已做了修改，将isDefault改为init并提至table-header中的mounted函数中传到名为sort的 mutation中，不知这样可以吗？如果可以，是否可以把init提到table-header的 props中的defaultSort的default属性中？ |
|
@PeanutWatson 帮你调整了一下的部分代码。核心逻辑没变。 |
|
|
@PeanutWatson 如果还有 bug 的话，提供一个链接吧。 |
FAKER-A
pushed a commit
to FAKER-A/element
that referenced
this pull request
May 7, 2019
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
|
@ziyoung 2.11又重现了 |
3 tasks
|
在用table组件的时候sort-change 会触发两次http的请求，有遇到过的吗，如何解决 |
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug when setting default-sort prop to Table, it will trigger sort-change function directly.
To Closes #13750