Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update french documentation, contributing guide and github templates #14418

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Update french documentation, contributing guide and github templates #14418

merged 3 commits into from
Feb 20, 2019

Conversation

IvanOdd
Copy link
Contributor

@IvanOdd IvanOdd commented Feb 19, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.
  • Update the french translation (fr-FR) according to the latest updates in the english doc, including the new Timeline component.
  • Add the CONTRIBUTING.fr-FR.md file.
  • Add a link in the PULL_REQUEST_TEMPLATE.md accordingly.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit d7dcfbd

https://deploy-preview-14418--element.netlify.com

@island205
Copy link
Contributor

Great work, Thank you for your contributions!

island205
island205 approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@island205 island205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@island205 island205 added this to the 2.6.0 milestone Feb 20, 2019
@island205 island205 merged commit 4ebbbdb into ElemeFE:dev Feb 20, 2019
@island205 island205 mentioned this pull request Mar 1, 2019
Merged
3 tasks
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
@IvanOdd
Docs: Update french documentation, contributing guide and github temp…
b9b613f 
…lates (ElemeFE#14418)

* Docs: update french translation (fr-FR)

* Contributing: add CONTRIBUTING.fr-FR.md

* GitHub templates: update PULL_REQUEST_TEMPLATE.md with french contributing guide
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
@IvanOdd @lzq4047
Docs: Update french documentation, contributing guide and github temp…
96b2c21 
…lates (ElemeFE#14418)

* Docs: update french translation (fr-FR)

* Contributing: add CONTRIBUTING.fr-FR.md

* GitHub templates: update PULL_REQUEST_TEMPLATE.md with french contributing guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@island205 island205 island205 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanOdd @element-bot @island205