Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getDOM递归问题 #14413

Merged
merged 2 commits into from
Feb 20, 2019
Merged

fix: getDOM递归问题 #14413

merged 2 commits into from
Feb 20, 2019

Conversation

Kcium
Copy link
Contributor

@Kcium Kcium commented Feb 19, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@Kcium Kcium changed the title getDOM的递归有问题 fix: getDOM递归问题 Feb 19, 2019
@element-bot
Copy link
Member

element-bot commented Feb 19, 2019

Deploy preview for element ready!

Built with commit 596fc58

https://deploy-preview-14413--element.netlify.com

@island205 island205 added this to the 2.6.0 milestone Feb 20, 2019
Copy link
Contributor

@island205 island205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ziyoung
Copy link
Contributor

ziyoung commented Feb 20, 2019

@island205 @KAionro 我怎么感觉这个函数可以去掉。

const dom = getDOM(this.$el);

this.$el 不可能是 TEXT_NODE。这个函数其实根本都没起作用。函数中的 if 根本没有执行,所以递归才没问题。

@island205
Copy link
Contributor

@ziyoung @KAionro 那直接去掉这个函数吧!

@ziyoung ziyoung merged commit df95baf into ElemeFE:dev Feb 20, 2019
@island205
Copy link
Contributor

Great work, Thank you for your contributions!

@island205 island205 mentioned this pull request Mar 1, 2019
3 tasks
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
* getDOM的递归有问题

* Popup: remove useless getDOM function
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
* getDOM的递归有问题

* Popup: remove useless getDOM function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants