[Dropdown Item] Add icon prop to dropdown-item #14088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for element ready! Built with commit 252944a |
|
@gabrielboliveira it's awesome.👍Now, the French doc has been added. Fetch the latest code and update the French doc. Don't worry about translation. |
ziyoung
approved these changes
Feb 20, 2019
|
@ziyoung done! |
|
Just realized I missed the Typescript definition.. Should I add it? |
|
@gabrielboliveira yes, you are right. I will merge this pr after you add it. |
|
@ziyoung Added. Now it looks good to go 👍 |
weisiren168
pushed a commit
to weisiren168/element
that referenced
this pull request
Jun 20, 2019
* Add icon prop to dropdown-item * Add French translation to DropdownItem Icon * Adding missing TypeScript definition to DropdownItem
lzq4047
pushed a commit
to lzq4047/element
that referenced
this pull request
May 22, 2020
* Add icon prop to dropdown-item * Add French translation to DropdownItem Icon * Adding missing TypeScript definition to DropdownItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.This is a new feature to add a new prop to Dropdown Item. It's now possible to add a icon 🎉