Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Date Picker When type = week and first DayOfWeek = 3, 2019-01-01 shows Wednesday, not Tuesday. #14523

Closed
xiaoxuefengnian opened this issue Feb 28, 2019 · 5 comments
Closed

[Bug Report] Date Picker When type = week and first DayOfWeek = 3, 2019-01-01 shows Wednesday, not Tuesday. #14523

xiaoxuefengnian opened this issue Feb 28, 2019 · 5 comments
Assignees
@wacky6
Labels
component: date-picker type: bug
Milestone
2.6.2

Comments

@xiaoxuefengnian
Copy link

Element UI version

2.4.11

OS/Browsers version

chrome

Vue version

2.6.7

Reproduction Link

https://jsfiddle.net/wLnje7t1/

Steps to reproduce

设置 DatePicker，
type = "week"，
picker-options="{firstDayOfWeek: 3}"，
查看日期为2019-01-01时的日期面板

What is Expected?

2019-01-01显示为周二

What is actually happening?

2019-01-01显示为周三
@element-bot element-bot changed the title [Bug Report] DatePicker 当 type="week" 并且 firstDayOfWeek=3 时，2019-01-01显示为周三，而不是实际的周二 [Bug Report] Date Picker When type = week and first DayOfWeek = 3, 2019-01-01 shows Wednesday, not Tuesday. Feb 28, 2019
@element-bot
Copy link
Member

Translation of this issue:

Element UI version

2.4.11

OS/Browsers version

Chrome

Vue version

2.6.7

Reproduction Link

https://jsfiddle.net/wLnje7t1/

Steps to reproduce

Set up Date Picker,

Type = week,
Picker-options="{first DayOfWeek: 3}"

View the Date Panel at 2019-01-01

What is Expected?

2019-01-01 is Tuesday

What is actually happening?

Wednesday, 2019-01-01

@xiaoxuefengnian
Copy link
Author

image

@island205 island205 added this to the 2.7.0 milestone Mar 5, 2019
@xiaoxuefengnian
Copy link
Author

我设置的怎么不生效哦 2.4.11版本的

可以看下 Reproduction Link 里的，目前我只发现2019年1月的有问题，2月以及后面没有问题
1月的，可以注意下2月开头几天
11
2月的
2

@wacky6 wacky6 reopened this Mar 5, 2019
sinchang added a commit to AuroraSparkDev/element that referenced this issue Mar 5, 2019
@sinchang
[date-picker]: fixes ElemeFE#14523
25b13da
@sinchang
Copy link
Contributor

sinchang commented Mar 5, 2019

@wacky6 Can I work this issue?

@wacky6
Copy link
Contributor

wacky6 commented Mar 6, 2019

Certainly, pr welcome

@sinchang sinchang mentioned this issue Mar 6, 2019
Merged
3 tasks
wacky6 pushed a commit that referenced this issue Mar 6, 2019
@sinchang @wacky6
date-picker: fix first-day-of-week computation (#14523)
b7ee84f 
Fixes #14523
@island205 island205 modified the milestones: 2.7.0, 2.6.2 Mar 18, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this issue Jun 20, 2019
@sinchang
date-picker: fix first-day-of-week computation (ElemeFE#14523)
a28b143 
Fixes ElemeFE#14523
lzq4047 pushed a commit to lzq4047/element that referenced this issue May 22, 2020
@sinchang @lzq4047
date-picker: fix first-day-of-week computation (ElemeFE#14523)
a823bac 
Fixes ElemeFE#14523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wacky6 wacky6

Labels
component: date-picker type: bug
Projects
None yet
Milestone
2.6.2
Development

No branches or pull requests
5 participants
@island205 @sinchang @xiaoxuefengnian @wacky6 @element-bot