Support Robo v1.X #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking The arg(), args() and option() methods in CommandArguments now escape the values passed in to them. There is now a rawArg() method if you need to add just one argument that has already been escaped.
ERROR: No logger set for Edge\QA\Task\ParallelExec. Use $this->task(Foo::class) rather than new Foo() in loadTasks to ensure the builder can initialize task the task, or use $this->collectionBuilder()->taskFoo() if creating one task from within another.
PHP Fatal error: Uncaught Error: Call to undefined method Edge\QA\Task\NonParallelExec::getOutput() Tasks must use TaskIO for output methods. It is no longer possible to use IO from a task. For direct access use Robo::output() (not recommended). https://github.com/EdgedesignCZ/phpqa/pull/57/files#diff-f9bcd99426b2eb566eabc2e8a09b18c2
ERROR: Declaration of QARunner::loadRoboFile() should be compatible with Robo\Runner::loadRoboFile($output)
Exit code is 0 when robo->execute isn't auto-exited https://github.com/consolidation/Robo/blob/0.7.2/src/Runner.php#L91 https://github.com/consolidation/Robo/blob/1.0.6/src/Runner.php#L159
|
@robertfausk: could you try this version? Thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #57, without dropping support for Robo v0.X