Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run only HHVM on Trusty due to Travis inconsistancy #55

Merged
merged 3 commits into from
Apr 11, 2017

Conversation

photodude
Copy link
Contributor

Some people claim that in some instances Travis can start slowly or run slowly. Reduce this issue by only running HHVM on trusty

Some people claim that in some instances Travis can start slowly or run slowly. Reduce this issue by only running HHVM on trusty
@photodude
Copy link
Contributor Author

@zdenekdrahos this PR should reduce the long runtimes you mentioned in #52 (comment)

I've seen some statements that Travis will randomly be slow to start. This PR reduces the reliance on Trusty. As far as I understand it, the random slow start is due to a travis infrastructure issue and is not necessarily isolated to trusty, it's just reported as more common with trusty.

@photodude
Copy link
Contributor Author

I've also moved the HHVM configuration setting for disabling the JIT before the composer lines. This should also help improve the overall testing speed.

@zdenekdrahos zdenekdrahos merged commit 4957d26 into EdgedesignCZ:master Apr 11, 2017
@zdenekdrahos
Copy link
Member

Thanks @photodude

@photodude photodude deleted the patch-1 branch April 11, 2017 15:17
@photodude
Copy link
Contributor Author

you are welcome.

@zdenekdrahos
Copy link
Member

@photodude: could this change cause that travis build isn't executed?
Merge request wasn't executed. PRs aren't executed... Travis/github integration is enabled.

screenshot from 2017-04-22 11 42 49

@photodude
Copy link
Contributor Author

@zdenekdrahos This change should not cause travis to fail to build. Sounds like a travis connection error (or possibly an issue with how github connects to travis).

I'll add another PR that will specify precise for all other builds rather than relying on the default setting, in case travis changed something. But even with that, you likely need to contact travis about the failures to build.

@photodude
Copy link
Contributor Author

@zdenekdrahos definitly a travis connection issue. the message continuous-integration/travis-ci — Waiting for status to be reported clearly says travis is not talking to your repo and your repo is waiting to hear from travis.

It's not a build failure, or failure to build it;s a connection issue.
you can see the build status on travis

the PR status says the PR builds are not being created, (there is an account setting for that)
it looks like the repo and travis are just not talking. So a connection or account setting issue.

you can see my travis account is building for PR #59
https://travis-ci.org/photodude/phpqa/builds/224702748

@zdenekdrahos
Copy link
Member

zdenekdrahos commented Apr 23, 2017

Thanks for you help. I've already contacted the github support.
Because I think that problem is at github side. There are no requests in travis.

@zdenekdrahos
Copy link
Member

FYI: Webhooks were disabled because EdgedesignCZ organization was downgraded to free plan while still having private repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants