Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new LocalSecurityChecker #214

Conversation

Florian-B
Copy link

@Florian-B Florian-B commented Jan 27, 2021

Add new LocalSecurityChecker (https://github.com/fabpot/local-php-security-checker) that replaces sensiolabs/security-checker (https://github.com/sensiolabs/security-checker)

@Florian-B Florian-B force-pushed the feature/add-local-security-checker branch from 1dcbf14 to 002ff42 Compare January 28, 2021 08:22
@Florian-B Florian-B force-pushed the feature/add-local-security-checker branch from 002ff42 to 6bb4830 Compare January 28, 2021 10:27
@paras-malhotra
Copy link
Contributor

There are several disadvantages of using local-php-security-checker including:

  1. It is licensed under the AGPLv3. This means if your app uses local-php-security-checker, it has to be licensed under AGPLv3. This makes it literally useless in any commercial and non-AGPLv3 apps.
  2. It includes binaries that depend on system architecture. So, this PR downloads the linux 386 binary but it will not work on other system architectures.
  3. It cannot be pulled by Composer and needs shell scripts to pull it in

I have proposed an alternative PR here: #215

@zdenekdrahos
Copy link
Member

Another disadvantage:

  • adding local-php-security-checker is BC for existing users, and keeping old security-checker is confusing for developers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants