Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load correct initial page in HTML report #133

Merged
merged 2 commits into from
Jun 13, 2018

Conversation

ndench
Copy link
Contributor

@ndench ndench commented Jun 11, 2018

This PR fixes an issue with the following flow:

  1. Run phpqa
  2. Open the html report for a given tool (ie. psalm, phpstan, etc)
  3. Fix issues listed in the report and rerun phpqa
  4. Refresh the page to see the updated report

Expected outcome:
The report for the tool is reloaded.

Actual outcome:
Taken back to the phpqa homepage and need to click into the original tool again.

This fix also allows you to go directly to a given tool. For example:

  1. Run phpqa
  2. Notice that only a single tool is failing (eg. psalm)
  3. Go directly to the report for that tool with it's hash (eg. phpqa.html#psalm)

PS. Sorry for all the whitespace changes, my editor automatically strips trailing whitespace on save.

Copy link
Member

@zdenekdrahos zdenekdrahos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great. I'll merge it when there are no .gitignore changes (add .idea to global .gitignore, not to every repository). Thanks

@zdenekdrahos zdenekdrahos changed the title Load correct page from hash Load correct initial page in HTML report Jun 11, 2018
@ndench
Copy link
Contributor Author

ndench commented Jun 13, 2018

No worries @zdenekdrahos, I didn't realise you could have a global .gitignore. I've removed .idea/ but can't seem to remove the extra newline from the end of the file. All my editors appear to add it.

@zdenekdrahos zdenekdrahos merged commit 8fd70bf into EdgedesignCZ:master Jun 13, 2018
@zdenekdrahos
Copy link
Member

Thanks, @ndench.

@ndench ndench deleted the fix-on-hash-change branch June 13, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants