Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: login link in the navbar #9893

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Panquesito7
Copy link
Member

Changes proposed

  • Fix login link in the navbar.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

I don't think this applies here.

Note to reviewers

None.

@SaraJaoude
Copy link
Member

There doesn't seem to be an issue associated with this PR? On this occasion we will review without an issue being opened.

In future, to ensure we have consistency and to help with the smooth running of the project could you please raise an issue and wait for the necessary steps as reflected in the Contributing Guide.

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is the e.preventDefault(), these changes will have no effect - but I like the idea of "just incase" something happens, /auth/login is an actual page where /login is not

@eddiejaoude eddiejaoude merged commit fd0567b into EddieHubCommunity:main Jan 12, 2024
13 checks passed
@Panquesito7 Panquesito7 deleted the fix_login_link branch January 14, 2024 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants