Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Update Gitpod.yml for Next.js #1966

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Update Gitpod.yml for Next.js #1966

merged 2 commits into from
Oct 14, 2022

Conversation

Cahllagerfeld
Copy link
Member

@Cahllagerfeld Cahllagerfeld commented Oct 14, 2022

Adjustments for Gitpod.yml in the new project setup

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 v2 labels Oct 14, 2022
# List the start up tasks. Learn more https://www.gitpod.io/docs/config-start-tasks/
tasks:
- name: Install npm depdencies
init: npm i
command: |
gp await-port 27017
mv .env.example .env
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm renaming the example env here to a regular one, so the dev command executes as expected.

When not doing this, it probably doesn't make sense to run dev because the database won't connect.
I personally would go with the solution that is currently in that PR, what do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍


vscode:
extensions:
- "asciidoctor.asciidoctor-vscode"
- bradlc.vscode-tailwindcss
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed the asciidoctor extension, because we don't use this anymore.
Other than that I added the tailwind extension, as we bring this in with nextjs, so people have intellisense for the classes.

@Cahllagerfeld Cahllagerfeld marked this pull request as ready for review October 14, 2022 15:26
Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

@eddiejaoude eddiejaoude merged commit 7c06597 into nextjs Oct 14, 2022
@eddiejaoude eddiejaoude deleted the cahllagerfeld/gitpod branch October 14, 2022 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants