Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Adds Lucy Macartney's profile #1866

Merged
merged 4 commits into from
Oct 16, 2022

Conversation

lmac-1
Copy link
Member

@lmac-1 lmac-1 commented Oct 2, 2022

Changes proposed

Adds Lucy Macartney's profile to LinkFree

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

Welcome @lmac-1! Thank you so much for your first pull request!

@github-actions github-actions bot added large Pull request with more than 30 changed lines ✍ chore: profile This label will be added on PR with request of Data json addition LGTM invalid Inappropriate or invalid for Hacktoberfest contributions labels Oct 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest.

Comment on lines 53 to 54
"color": "black",
"description": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove this field if you're not going to use it, IMO.

Suggested change
"color": "black",
"description": ""
"color": "black"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it! Will make the changes today, thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the unnecessary line. Let me know if anything else is incorrect. Thanks!

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! 🎉

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile looks good to me, but accidentally you've committed icons.md, so please revert the changes in the icons.md file!

PR adding profile should only contain your file!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions large Pull request with more than 30 changed lines LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants