fix: logging when there are errors

EddieHubCommunity · Nov 6, 2023 · 5b641dd · 5b641dd
1 parent 18c10bc
commit 5b641dd
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/pages/api/account/manage/settings.js b/pages/api/account/manage/settings.js
@@ -203,6 +203,11 @@ export async function updateSettingsApi(context, username, data) {
           body: JSON.stringify({ name: data.domain }),
         });
         domainAddJson = await domainAddRes.json();
+        if (domainAddJson.error) {
+          updateDomain(username, beforeUpdate.domain);
+          log.error(domainAddUrlError);
+          return { error: domainAddUrlError };
+        }
         log.info(
           domainAddJson,
           `domain ${data.domain} added to team for: ${username}`,
@@ -213,12 +218,6 @@ export async function updateSettingsApi(context, username, data) {
         return { error: domainAddUrlError };
       }
 
-      if (domainAddJson.error) {
-        updateDomain(username, beforeUpdate.domain);
-        log.error(domainAddUrlError);
-        return { error: domainAddUrlError };
-      }
-
       log.info(
         `attempting to add domain "${data.domain}" to the project for: ${username}`,
       );
@@ -236,6 +235,11 @@ export async function updateSettingsApi(context, username, data) {
           body: JSON.stringify({ name: data.domain }),
         });
         domainProjectAddJson = await domainProjectAddRes.json();
+        if (domainProjectAddJson.error) {
+          updateDomain(username, beforeUpdate.domain);
+          log.error(domainProjectAddJsonError);
+          return { error: domainProjectAddJsonError };
+        }
         log.info(
           domainProjectAddJson,
           `domain ${data.domain} added to project for: ${username}`,
@@ -245,12 +249,6 @@ export async function updateSettingsApi(context, username, data) {
         return { error: domainProjectAddJsonError };
       }
 
-      if (domainProjectAddJson.error) {
-        updateDomain(username, beforeUpdate.domain);
-        log.error(domainProjectAddJsonError);
-        return { error: domainProjectAddJsonError };
-      }
-
       if (getProfile.settings?.domain) {
         const vercel = await vercelDomainStatus(
           username,