Angular 18.1 and all JS deps #10322

Except: - @types/node, we run on node 18
Ecodev · Jul 15, 2024 · 6c53b7e · 6c53b7e
1 parent d752c96
commit 6c53b7e
Show file tree

Hide file tree

Showing 7 changed files with 3,214 additions and 2,760 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -73,6 +73,38 @@
                         }
                     }
                 ],
+                "@typescript-eslint/restrict-plus-operands": [
+                    "error",
+                    {
+                        // Allow some flexibility
+                        "allowAny": true,
+                        "allowBoolean": true,
+                        "allowNullish": true,
+                        "allowNumberAndString": true
+                    }
+                ],
+                "@typescript-eslint/restrict-template-expressions": [
+                    "error",
+                    {
+                        // Allow some flexibility
+                        "allowAny": true,
+                        "allowBoolean": true,
+                        "allowNullish": true,
+                        "allowNumber": true
+                    }
+                ],
+                "@typescript-eslint/no-unused-expressions": [
+                    "error",
+                    {
+                        "allowTernary": true
+                    }
+                ],
+                "@typescript-eslint/no-unused-vars": [
+                    "error",
+                    {
+                        "caughtErrors": "none"
+                    }
+                ],
                 "no-restricted-globals": [
                     "error",
                     "atob",

diff --git a/package.json b/package.json
@@ -41,44 +41,39 @@
         "url": "https://github.com/Ecodev/angular-natural-gallery/issues"
     },
     "devDependencies": {
-        "@angular-devkit/build-angular": "^17.2.1",
-        "@angular-eslint/builder": "^17.2.1",
-        "@angular-eslint/eslint-plugin": "^17.2.1",
-        "@angular-eslint/eslint-plugin-template": "^17.2.1",
-        "@angular-eslint/schematics": "^17.2.1",
-        "@angular-eslint/template-parser": "^17.2.1",
-        "@angular/animations": "^17.2.2",
-        "@angular/cli": "^17.2.1",
-        "@angular/common": "^17.2.2",
-        "@angular/compiler": "^17.2.2",
-        "@angular/compiler-cli": "^17.2.2",
-        "@angular/core": "^17.2.2",
-        "@angular/language-service": "^17.2.2",
-        "@angular/platform-browser": "^17.2.2",
-        "@angular/platform-browser-dynamic": "^17.2.2",
-        "@angular/router": "^17.2.2",
+        "@angular-devkit/build-angular": "^18.1.0",
+        "@angular/animations": "^18.1.0",
+        "@angular/cli": "^18.1.0",
+        "@angular/common": "^18.1.0",
+        "@angular/compiler": "^18.1.0",
+        "@angular/compiler-cli": "^18.1.0",
+        "@angular/core": "^18.1.0",
+        "@angular/language-service": "^18.1.0",
+        "@angular/platform-browser": "^18.1.0",
+        "@angular/platform-browser-dynamic": "^18.1.0",
+        "@angular/router": "^18.1.0",
         "@ecodev/natural-gallery-js": "^10.0.1",
         "@playwright/test": "^1.35.1",
         "@types/jasmine": "~5.1.4",
         "@types/jasminewd2": "^2.0.9",
         "@types/node": "^16.0",
-        "@typescript-eslint/eslint-plugin": "^7.0.2",
-        "@typescript-eslint/parser": "^7.0.2",
-        "eslint": "^8.53.0",
+        "angular-eslint": "18.1.0",
+        "eslint": "^9.6.0",
         "jasmine-core": "~5.1.2",
         "jasmine-spec-reporter": "~7.0.0",
         "karma": "~6.4.2",
         "karma-chrome-launcher": "~3.2.0",
         "karma-coverage-istanbul-reporter": "~3.0.2",
         "karma-jasmine": "~5.1.0",
         "karma-jasmine-html-reporter": "^2.1.0",
-        "ng-packagr": "^17.2.0",
+        "ng-packagr": "^18.1.0",
         "photoswipe": "^5.3.7",
-        "prettier": "3.2.5",
+        "prettier": "3.3.3",
         "rxjs": "^7.8.1",
         "ts-node": "^10.9.1",
         "tslib": "^2.5.3",
-        "typescript": "~5.3.3",
+        "typescript": "~5.5.3",
+        "typescript-eslint": "8.0.0-alpha.38",
         "zone.js": "~0.14.4"
     },
     "dependencies": {}

diff --git a/projects/angular-natural-gallery/package.json b/projects/angular-natural-gallery/package.json
@@ -14,7 +14,7 @@
         "tslib": "^2.5.3"
     },
     "peerDependencies": {
-        "@angular/common": "^17.2.0",
-        "@angular/core": "^17.2.0"
+        "@angular/common": "^18.1.0",
+        "@angular/core": "^18.1.0"
     }
 }
diff --git a/src/index.html b/src/index.html
@@ -9,6 +9,7 @@
         <link rel="icon" type="image/x-icon" href="favicon.ico" />
     </head>
     <body>
-        <app-root class="defaultDark" />
+        <!-- eslint-disable-next-line @angular-eslint/template/prefer-self-closing-tags -->
+        <app-root class="defaultDark"></app-root>
     </body>
 </html>
diff --git a/src/main.ts b/src/main.ts
@@ -10,4 +10,6 @@ if (environment.production) {
 
 bootstrapApplication(AppComponent, {
     providers: [importProvidersFrom(BrowserModule), provideAnimations()],
-}).catch(err => console.log(err));
+}).catch((err: unknown) => {
+    console.error(err);
+});
diff --git a/tsconfig.json b/tsconfig.json
@@ -5,7 +5,7 @@
         "outDir": "./dist/out-tsc",
         "sourceMap": true,
         "declaration": false,
-        "downlevelIteration": true,
+        "esModuleInterop": true,
         "experimentalDecorators": true,
         "module": "ES2022",
         "moduleResolution": "node",
@@ -23,7 +23,6 @@
             "@ecodev/angular-natural-gallery/*": ["dist/angular-natural-gallery/*"],
             "photoswipe/lightbox": ["./node_modules/photoswipe/dist/types/photoswipe.d.ts"]
         },
-        "allowSyntheticDefaultImports": true,
         "noImplicitOverride": true,
         "useDefineForClassFields": false
     },