Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the Carbon isotope land-use change bug #694

Merged
merged 13 commits into from
Apr 26, 2019
Merged

Fix for the Carbon isotope land-use change bug #694

merged 13 commits into from
Apr 26, 2019

Commits on Apr 17, 2019

  1. Fix ESCOMP#675 Carbon isotope problem where bulk soil carbon gets mod… 

    …ified when only isotopic soil carbon should have
    @ekluzek
    ekluzek committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    9c350e5 View commit details
    Browse the repository at this point in the history

  2. Add LCISO test in

    @ekluzek
    ekluzek committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    3fb2ccc View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Actually get the LCISO test working

    @ekluzek
    ekluzek committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    7aa80d9 View commit details
    Browse the repository at this point in the history

  2. Remove the user mod that removes the C13/C14 fields, not needed it ha… 

    …s to be in the test itself
    @ekluzek
    ekluzek committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    0dc683d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Add carbon isotope test with land-use change

    @ekluzek
    ekluzek committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    c88fbf3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'escomp/master' into cisofix

    @ekluzek
    ekluzek committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    e941f59 View commit details
    Browse the repository at this point in the history

  3. Change ciso test so that you don't have to exclude all the carbon iso… 

    …tope fields
    @ekluzek
    ekluzek committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    0b2970e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. Add note about this test needing to go beyond the year boundary, so 1… 

    …3 months is required
    @ekluzek
    ekluzek committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    92478c1 View commit details
    Browse the repository at this point in the history

  2. Use universal_newlines in call to subprocess.Popen 

    Without this, we run into the issue noted in
ESCOMP#692. This fixes the problem. I
don't fully understand the need for this, but from reading some stack
overflow posts, I'm not surprised that we need this.

Resolves ESCOMP#692
    @billsacks
    billsacks committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    87c09c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Merge remote-tracking branch 'billsacks/runsystests_py3' into cisofix 

    Add fix to run_sys_tests for ESCOMP#692
    @ekluzek
    ekluzek committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    49fcb9b View commit details
    Browse the repository at this point in the history

  2. Update README file with some additional top level things that have ha… 

    …ppened
    @ekluzek
    ekluzek committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    bc68c56 View commit details
    Browse the repository at this point in the history

  3. First pass at ChangeLog

    @ekluzek
    ekluzek committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    2b59d74 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Update ChangeLog

    @ekluzek
    ekluzek committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    5b1007c View commit details
    Browse the repository at this point in the history