Fix for the Carbon isotope land-use change bug #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified when only isotopic soil carbon should have
…s to be in the test itself
…3 months is required
Without this, we run into the issue noted in ESCOMP#692. This fixes the problem. I don't fully understand the need for this, but from reading some stack overflow posts, I'm not surprised that we need this. Resolves ESCOMP#692
Add fix to run_sys_tests for ESCOMP#692
ekluzek
added
PR status: ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a test that verifies that the code is identical when carbon isotopes are on or off. And add a fix to the bug where answers changed for land-use change cases.
Specific notes
Contributors other than yourself, if any:@klindsey @billsacks
CTSM Issues Fixed (include github issue #): #675 #686
Fixes #675
Fixes #686
Are answers expected to change (and if so in what way)? Yes!
Only for cases with transient land-use change AND either use_c13 and/or use_c14 turned on.
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any: Standard on hobart and nag, PASS as expected