-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Point to a new cime tag #237
Conversation
This cime tag auto-detects model=cesm based on the presence of manage_externals
@ekluzek It feels like this change could be combined with something else you're working on. However, I'm also happy to bring it to master separately. What would work better for you? (@billsacks I currently don't have any cime changes to make. But, I can certainly pull this update to the cime branch for ctsm in my next ctsm tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@ekluzek since I went ahead and kicked off testing, should I just bring this change to master on its own tomorrow morning, assuming all tests have passed? If so, I'm inclined to make a separate tag for this, so that people can point to a working tag from github, if that sounds good to you. Let me know if you have any thoughts on this. |
Hey OK. Yes that sounds fine since you are already doing testing.
…On Jan 29, 2018 7:58 PM, "Bill Sacks" ***@***.***> wrote:
@ekluzek <https://github.com/ekluzek> since I went ahead and kicked off
testing, should I just bring this change to master on its own tomorrow
morning, assuming all tests have passed? If so, I'm inclined to make a
separate tag for this, so that people can point to a working tag from
github, if that sounds good to you. Let me know if you have any thoughts on
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#237 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALAswGA6Ivj1BhRa9xeLmLr_Xc3MAxnbks5tPoVagaJpZM4Rxp1Z>
.
|
aedf01c
to
95a2ebf
Compare
Fix auto-detection of CIME_MODEL in a standalone checkout The auto-detection of whether CIME_MODEL is acme or cesm is broken in standalone checkouts of clm4_5_18_r273. (This auto-detection relied on whether there was an SVN_EXTERNAL_DIRECTORIES file present at the top level.) This tag points to a new cime version that fixes this issue.
Enable build with ESMX and introduce export_all
This cime tag auto-detects model=cesm based on the presence of
manage_externals
The diffs in this cime tag are simply:
These changes are already on cime master (made by @jedwards4b ); here I have cherry-picked them onto the cime branch that we're using.
Fixes #238