Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CCPPized check_energy_chng and check_energy_fix #1180

Open
wants to merge 10 commits into
base: cam_development
Choose a base branch
from

Conversation

jimmielin
Copy link
Member

Closes #1138

Purpose of changes

  • CCPPize check_energy_chng and check_energy_fix
    CAM interfaces have been kept in check_energy.F90 instead of a new module because check_tracers is not yet CCPPized, there are other non-CCPPized routines in module, and for compatibility with FV3 external calls
  • Save air_composition cp_or_cv_dycore into state snapshot
  • Separate out "energy_formula_physics"/"energy_formula_dycore" definitions used in get_hydrostatic_energy from dyn_tests_utils "vcoord" for an eventual change in SIMA.

Related issues

Files changed:

List all files eliminated: N/A

List all files added and what they do:
- separate out energy formula definitions used in get_hydrostatic_energy from dyn_tests_utils "vcoord"
A       src/utils/cam_thermo_formula.F90

List all existing files that have been modified, and describe the changes:

Update atmos_phys external with CCPPized check_energy
M       .gitmodules
M       bld/configure
M       src/atmos_phys

Save cp_or_cv_dycore in state snapshot
M       src/control/cam_snapshot_common.F90

New CAM interfaces to CCPPized routines, when avaialble
M       src/physics/cam/check_energy.F90

Update calls to CCPPized routines, when available
M       src/physics/cam/physpkg.F90
M       src/physics/cam/zm_conv_intr.F90
M       src/physics/cam7/physpkg.F90
M       src/physics/simple/physpkg.F90
M       src/physics/spcam/crm_physics.F90
M       src/physics/spcam/spcam_drivers.F90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant