This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Keep http_plugin_impl alive while connection objects are alive - 2.0 #9516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…their destructors need the io_context of the http_plugin_impl thread_pool io_context
|
@heifner Will you be able to review this PR? Thanks! |
|
@nksanthosh This is all my code. Doesn't make sense for me to review it. |
heifner
changed the title
swatanabe-b1
approved these changes
Sep 24, 2020
vzqzhang
force-pushed
the
http-life-develop-rebase-2.0.x
branch
from
f1ceb20
to
811b9d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
When the nodeos is killed, the thread_pool and associated io_context of the http_plugin_impl should keep alive for the lifetime of the connection object
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions