This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Prevent an older version of g++ to build eosio #9314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than g++ 8.0. g++7.5 will fail to build the tests.
|
fwiw I tried building 2.0.0 with gcc 7.5 and it failed (not that it should be a surprise since the troublesome file has not been changed in 2.0.x). So LGTM -- I don't think anyone out there would likely be using a 2.0.x with gcc 7 |
jeffreyssmith2nd
approved these changes
Jul 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Updating the CMakeLists.txt to prevent older g++ versions to build eosio.
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions