Migrate to b7a 1.0.3 and introduce basic auth for the hub service #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryamZi
changed the title
MaryamZi
commented
Nov 5, 2019
chamil321
approved these changes
Nov 5, 2019
sanjiva
reviewed
Nov 7, 2019
| log:printWarn("error decoding topic, using the original form: " + topic + ". Error: " + decodedTopic.toString()); | ||
| } | ||
|
|
||
| if (topic != JSON_RESULTS_TOPIC) { |
There was a problem hiding this comment.
We need to support image sending too .. so user has to subscribe to both the JSON and the image.
See: #48
There was a problem hiding this comment.
We can fix this after merging this code.
sanjiva
reviewed
Nov 7, 2019
| if (remResult is error) { | ||
| log:printError("error removing existing subscription for username: " + username, remResult); | ||
| } | ||
| updateUserCallback(username, callback); |
There was a problem hiding this comment.
Add a log showing that we added a new subscription and show the callback URL
sanjiva
reviewed
Nov 7, 2019
|
|
||
| if callbackMap.hasKey(username) { | ||
| error? remResult = hubVar.removeSubscription(topic, callbackMap.get(username)); | ||
| log:printInfo("Removing existing subscription for username: " + username); |
sanjiva
approved these changes
Nov 7, 2019
MaryamZi
added a commit
to MaryamZi/Results-Dist
that referenced
this pull request
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$title.
To Do - persist registered callbacks vs username. - Done