-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FreeBSD][Apple] Implement fallback frequency calculation #251
Conversation
cpufetch does not accept pull requests, see the contributing guidelines for details |
General question, why is this needed? Have you found a x86 CPU which does not get the frequency reported when using FreeBSD and macOS? Which CPU is that? |
For me it's AMD Ryzen 5 3500, it reports |
I see, makes sense. Then please have a look at my review comment. |
Maybe I don't understood something but referenced commit nor next commits doesn't change anything for x86/amd64. (kinda offtopic for this issue) BTW cpufetch doesn't work on ARM64 FreeBSD (because nobody ported) and u-boot doesn't expose many information about CPU, some related sysctls for rpi3b are
(neofetch on this platform simply says hw.model value which doesn't represent real cpu name) |
There is no visible change in x86. What changed is the fact that you can now include
Regarding what you mention about ARM64 in FreeBSD, if you have a proper error message from cpufetch please open an issue and we'll see what can be done to support it 👍 . |
Looks good to me! Please rebase and confirm this works for your hardware. If this is the case, I'll merge this into master shortly. |
Yes (btw this PR was already squashed) |
Merged, thank you for your contribution! 👍 |
This PR is a recreation of #232 because seems like @Dr-Noob is now ready to merge it.