-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensitivity analysis to framework class #249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing indirect dependence of
sensitivity_plot
onsensitivity_analysis
by adding new input valuesrho
,level
andnull_hypothesis
.Moving
sensitivity_plot
,sensitivity_analysis
,_calc_robustness_value
and_calc_sensitivity_analysis
fromDoubleML
toDoubleMLFramework
class. The computation of confidence intervals over multiple repetitions is now also based on medians not aggregated variances.Further, this will allow sensitivity analysis for differences in potential outcomes as proposed in #245
Comments
Most of the computations are only valid for identical outcomes and cond. expectations.
PR Checklist
Please fill out this PR checklist (see our contributing guidelines for details).