Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch 1 #7

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Patch 1 #7

wants to merge 14 commits into from
+29 −19

Conversation

Muzzarino
Copy link
Contributor

No description provided.

JoshuaMKW
JoshuaMKW requested changes Nov 13, 2022
View reviewed changes
Copy link
Member

@JoshuaMKW JoshuaMKW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things

src/globals.cpp Show resolved Hide resolved
JoshuaMKW
JoshuaMKW requested changes Nov 17, 2022
View reviewed changes
Copy link
Member

@JoshuaMKW JoshuaMKW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you have an extra closing brace at the end of BetterSMS::getFrameRate() {...}

include/BetterSMS/module.hxx Outdated Show resolved Hide resolved
src/module.cpp Outdated Show resolved Hide resolved
src/globals.cpp Show resolved Hide resolved
src/globals.cpp Show resolved Hide resolved
src/globals.cpp Show resolved Hide resolved
@JoshuaMKW
Copy link
Member

After more testing, so far having WIDE return 700 creates a more accurate result than 797

JoshuaMKW
JoshuaMKW requested changes Nov 18, 2022
View reviewed changes
src/globals.cpp Show resolved Hide resolved
src/patches/widescreen.cpp Outdated Show resolved Hide resolved
@RibShark RibShark mentioned this pull request Jan 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaMKW JoshuaMKW JoshuaMKW requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Muzzarino @JoshuaMKW