Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow directories with white-spaces to be passed #63

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Allow directories with white-spaces to be passed #63

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
797fe4d
extended split_list_arg to split by whitespaces while ignoring filepa…
rjwignar Dec 6, 2023
bacf977
moved path normalization logic from list_files() to split_list_arg()
rjwignar Dec 6, 2023
4cfac55
moved path normalization logic from split_list_arg() to normalize_pat…
rjwignar Dec 7, 2023
fee86da
refactored split_list_arg()
rjwignar Dec 7, 2023
d4653f9
added comment for regex pattern in split_list_arg()
rjwignar Dec 7, 2023
5b3cd8c
removed commented-out draft code from split_list_arg() and list_files()
rjwignar Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion run-clang-format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import subprocess
import sys
import traceback
import re
from distutils.util import strtobool

from functools import partial
Expand Down Expand Up @@ -241,14 +242,23 @@ def print_trouble(prog, message, use_colors):
error_text = bold_red(error_text)
print("{}: {} {}".format(prog, error_text, message), file=sys.stderr)

def normalize_paths(paths):
"""
Normalizes backward slashes in each path in list of paths
Ex)
"features/Test\ Features/feature.cpp" => "features/Test Features/feature.cpp"
"""
return [path.replace("\\","") for path in paths]

def split_list_arg(arg):
"""
If arg is a list containing a single argument it is split into multiple elements.
Otherwise it is returned unchanged
Workaround for GHA not allowing list arguments
"""
return arg[0].split() if len(arg) == 1 else arg
# pattern matches all whitespaces except those preceded by a backslash, '\'
pattern = r'(?<!\\)\s+'
return normalize_paths(re.split(pattern, arg[0])) if len(arg) == 1 else arg


def main():
Expand Down