Fix Preview present even when there is no corresponding file #30585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Aug 10, 2024
eldy
added
the
Discussion
|
hello @MaximilienR-easya i do not have the bug on my dolibarr ... on /comm/index.php?mainmenu=commercial&leftmenu= there is now preview icon:
could you please explain to us where is the bug ? thanks, |
The problem is not on comm/index.php but in comm/card.php. |
|
Here is the bug!
|
rycks
approved these changes
Sep 18, 2024
lvessiller-opendsi
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
We got case where in the client page, in the list of propale, contract, etc, case where one of them don't have a PDF but still have a preview link.
We add a check to verify if the file is existing and if it's non-existent, we don't show a preview link.