Retroport: FIX determine multi-currency price on object line create tpl (#28021) #30535
Conversation
|
Sorry, but you put "NEW" in the title of this PR and it seems to be a FIX. |
altairis-benjamin
changed the title
|
I changed the title, but I juste copied/pasted the original PR title. In fact, currently, when you add a product on a supplier order, the price taken into account is the one in your own currency. With this fix, the price in its original currency is used to calculate all prices: the price in supplier's currency is the good one, and the one in your currency is also correct. |
| } else { | ||
| jQuery("#price_ht").val(up_locale); | ||
| var multicurrency_code = $('option:selected', this).attr('data-multicurrency-code'); // When select is done from HTML select | ||
| if (multicurrency_code == undefined) { multicurrency_code = jQuery('#idprodfournprice').attr('data-multicurrency-code'); } // When select is done from HTML input with ajax autocomplete |
There was a problem hiding this comment.
Why to use here "== undefined" and not "typeof multicurrency_code === 'undefined'" like in other parts of this JS script ?
There was a problem hiding this comment.
Only because it's a back port of an existing PR. Maybe this change should also be done in develop?
There was a problem hiding this comment.
Yes, I think.
@eldy What is your advice ?
There was a problem hiding this comment.
As we are in a v18 submission, and it is a backport, code must be the much as possible similar than original,even if code is not as "clean" as we can.
eldy
added
the
Pending analysis of PR (maintenance team)
Some PR are difficult to validate without testing it. So you should have environment in v18 dedicated to validate PR. I recommand to have one environment per version with similar data, so if a trouble occurs in v18, you can compare easily with previous v17 or following V19. |
Related to the PR #30473 but with a clean commit.