fix #2810 #30251
Closed
fix #2810 #30251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jul 4, 2024
| @@ -98,6 +98,16 @@ | |||
|
|
|||
| print load_fiche_titre(' ', $resultboxes['selectboxlist'], '', 0, '', 'titleforhome'); | |||
|
|
|||
| if (DOL_VERSION != $conf->global->MAIN_VERSION_LAST_UPGRADE) { | |||
There was a problem hiding this comment.
This should not be required anymore.
We have this in current main.inc.php
// If an upgrade process is required, we call the install page.
$checkifupgraderequired = false;
if (getDolGlobalString('MAIN_VERSION_LAST_UPGRADE') && getDolGlobalString('MAIN_VERSION_LAST_UPGRADE') != DOL_VERSION) {
$checkifupgraderequired = true;
}
if (!getDolGlobalString('MAIN_VERSION_LAST_UPGRADE') && getDolGlobalString('MAIN_VERSION_LAST_INSTALL') && getDolGlobalString('MAIN_VERSION_LAST_INSTALL') != DOL_VERSION) {
$checkifupgraderequired = true;
}
if ($checkifupgraderequired) {
etc...
and if upgrade is required, a redirect to the upgrade process is automatically done. No choice.
So i think we can close the issue, the oldest one ?!
There was a problem hiding this comment.
Yes, that doesn't seem necessary any more. The issue should have been closed a long time ago.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2810
Time to fix oldest open issue :)