NEW : Duplicate ref_client from order origin to intervention. #30000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an intervention from an order, duplicate the ref_client (as is already done for public and private notes).
eldy
reviewed
Jun 15, 2024
htdocs/fichinter/card.php
Outdated
| @@ -882,6 +882,7 @@ | |||
|
|
|||
| $soc = $objectsrc->thirdparty; | |||
|
|
|||
| $ref_client = (!empty($objectsrc->ref_client) ? $objectsrc->ref_client : GETPOST('ref_client', 'alpha')); | |||
There was a problem hiding this comment.
Imagine you clone an intervention from a proposal.
The proposal has the ref PRABC for you and the proposal has the ref PR456 on customer side (so ref_client is PR456).
If you copy the ref of proposal into the intervention, you will got the ref of intervention that is
IN123 and the reference of this intervention into the customer system of the client will be saved as PR456.
But this is a reference of a proposal not of an intervention. You are mixing apple and pear here. So i suggest you introduce a hidden option
INTERVENTION_SET_CUSTOMER_PROPOSAL_REF_WITH_CUSTOMER_INTERVENTION_REF
eldy
added
the
PR to fix or conflict to solve
Add the INTERVENTION_SET_CUSTOMER_PROPOSAL_REF_WITH_CUSTOMER_INTERVENTION_REF hidden option under @eldy's advice.
|
Hello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW[Duplicate ref_client order origin to intervention]
When creating an intervention from an order, duplicate the ref_client (as is already done for public and private notes).