-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use grunt-sass instead of grunt-contrib-sass #287
Conversation
grunt-sass is a faster SASS compiler updated gruntfile.js to use grunt-sass some cleanups on gruntfile.js
I don't think it works. I've tried using LibSass before but I think it doesn't support the syntax we use in _colors.scss. See #161 I also checked it out and tested it. It doesn't throw errors, but also didn't compile for me. |
Ah I see. I didn't try viewing the file that it compiles. I just ran Thanks! Closing PR. |
@Dogfalo libsass should support the map syntax in |
Interesting, it's possible support was added recently. In which case in not
|
Perhaps clean out your node_modules and re-install? |
I'll try that in a bit.
|
Good call, after deleting all my |
@Dogfalo if you want, I can create another PR for you on this. |
@Dogfalo I see that we are using it already in the recent commits. Cool! Pulling it now. |
chore: merge upstream changes
grunt-sass
is a lot faster thangrunt-sass-contrib
that this project is using. It's built on top of a C/C++ implementation of SASS compiler. It lacks support for SASS style, but I don't think we're using that syntax at all in this project, so it should be fine (correct me if I'm wrong!).run
npm install
thengrunt
From
grunt-sass
repo: