Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grunt-sass instead of grunt-contrib-sass #287

Closed
wants to merge 1 commit into from
Closed

Use grunt-sass instead of grunt-contrib-sass #287

wants to merge 1 commit into from

Conversation

afifsohaili
Copy link
Contributor

grunt-sass is a lot faster than grunt-sass-contrib that this project is using. It's built on top of a C/C++ implementation of SASS compiler. It lacks support for SASS style, but I don't think we're using that syntax at all in this project, so it should be fine (correct me if I'm wrong!).

run npm install then grunt

From grunt-sass repo:

This task uses libsass which is an experimental Sass compiler in C++. In contrast to the original Ruby compiler, this one is much faster, but is missing some features, though improving quickly. It also doesn't support Compass. Check out grunt-contrib-sass if you prefer something more stable, but slower.

grunt-sass is a faster SASS compiler
updated gruntfile.js to use grunt-sass
some cleanups on gruntfile.js
@Dogfalo
Copy link
Owner

Dogfalo commented Dec 17, 2014

I don't think it works. I've tried using LibSass before but I think it doesn't support the syntax we use in _colors.scss.

See #161

I also checked it out and tested it. It doesn't throw errors, but also didn't compile for me.

@afifsohaili
Copy link
Contributor Author

Ah I see. I didn't try viewing the file that it compiles. I just ran grunt and it didn't throw any errors and I thought it was good.

Thanks! Closing PR.

@tnguyen14
Copy link

@Dogfalo libsass should support the map syntax in colors.scss. In fact, I am using gulp-sass, which uses libsass under the hood and it works fine. See here http://sass-compatibility.github.io/#map_data_type

@Dogfalo
Copy link
Owner

Dogfalo commented Dec 17, 2014

Interesting, it's possible support was added recently. In which case in not
sure why it wouldn't compile in the pull request.
On Dec 17, 2014 10:34 AM, "Tri Nguyen" notifications@github.com wrote:

@Dogfalo https://github.com/Dogfalo libsass should support the map
syntax in colors.scss. In fact, I am using gulp-sass, which uses libsass
under the hood and it works fine. See here
http://sass-compatibility.github.io/#map_data_type


Reply to this email directly or view it on GitHub
#287 (comment).

@tnguyen14
Copy link

Perhaps clean out your node_modules and re-install?

@Dogfalo
Copy link
Owner

Dogfalo commented Dec 17, 2014

I'll try that in a bit.
On Dec 17, 2014 10:44 AM, "Tri Nguyen" notifications@github.com wrote:

Perhaps clean out your node_modules and re-install?


Reply to this email directly or view it on GitHub
#287 (comment).

@Dogfalo
Copy link
Owner

Dogfalo commented Dec 20, 2014

Good call, after deleting all my node_modules, it is now compiling properly!

@afifsohaili
Copy link
Contributor Author

@Dogfalo if you want, I can create another PR for you on this.

@afifsohaili
Copy link
Contributor Author

@Dogfalo I see that we are using it already in the recent commits. Cool! Pulling it now.

Smankusors pushed a commit to Smankusors/materialize that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants