Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing all the print calls by calls to log #267

Open
Minigrim0 opened this issue Oct 26, 2022 · 6 comments
Open

Consider replacing all the print calls by calls to log #267

Minigrim0 opened this issue Oct 26, 2022 · 6 comments
Assignees
@amrutharajashekar
Labels
Good first issue

Comments

@Minigrim0
Copy link
Contributor

Using print calls for system messages is a bad practice, let's replace it by calls to a logger's log.
Maybe we can add some logging in some places where there is nothing at the moment.

Logging Docs
@Minigrim0 Minigrim0 changed the title Consider replacing all the print calls by a call to log Consider replacing all the print calls by calls to log Oct 26, 2022
@C4ptainCrunch
Copy link
Contributor

Indeed, it seems much cleaner, go for it !

@Minigrim0
Copy link
Contributor Author

Indeed, it seems much cleaner, go for it !

I put the Good First issue label so that anyone can start working on the project with this :)

@amrutharajashekar
Copy link

Hi, can i work on this issue ? I would like to contribute .
Thanks

amrutharajashekar added a commit to amrutharajashekar/DocHub that referenced this issue Oct 29, 2022
@amrutharajashekar
DocHub-ULB#267 replacing all the print calls by calls to log
88b888e
@amrutharajashekar amrutharajashekar mentioned this issue Oct 29, 2022
Closed
@amrutharajashekar
Copy link

Hi I have submitted the MR( #272 ) .
Please let me know if any optimisations or changes are required.
Thanks

@C4ptainCrunch
Copy link
Contributor

Hi @amrutha1098 !

Thank you for the pull request ! I'm curious, what gave you the idea of contributing to DocHub ? Are you a student at ULB or a member of Urlab ? Or is it the "good first issue" label ?
In any case, thank you and welcome 🤗

@C4ptainCrunch C4ptainCrunch linked a pull request Oct 31, 2022 that will close this issue
Replacing all the print calls by calls to log #272
Closed
@C4ptainCrunch C4ptainCrunch mentioned this issue Oct 31, 2022
Open
amrutharajashekar added a commit to amrutharajashekar/DocHub that referenced this issue Oct 31, 2022
@amrutharajashekar
DocHub-ULB#267 fixing the pre-commit issue
8eca03d
@amrutharajashekar
Copy link

HI @C4ptainCrunch , I actually came across this issue though "good first issue" label.
I am glad i was able to contribute to this project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amrutharajashekar amrutharajashekar

Labels
Good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing all the print calls by calls to log amrutharajashekar/DocHub
3 participants
@C4ptainCrunch @amrutharajashekar @Minigrim0