Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapper to fit response with needed schema #25

Closed
wants to merge 13 commits into from
Closed

Add mapper to fit response with needed schema #25

wants to merge 13 commits into from

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Mar 14, 2019

Add mapper in order to be able to format response according to VSF required schema.
In order to resolve: #24

@pkarw
Copy link
Contributor

pkarw commented Mar 14, 2019

I think that the best person to review this mappers is @afirlejczyk

@pkarw pkarw requested a review from afirlejczyk March 14, 2019 09:27
@afirlejczyk afirlejczyk removed their request for review March 18, 2019 18:41
@mtarld mtarld marked this pull request as ready for review April 23, 2019 13:56
@pkarw pkarw requested a review from afirlejczyk April 24, 2019 12:48
Copy link

@sandermangel sandermangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! My only direct concern here is the hardcoded fields. Not sure if that causes issues with 3rd party modules etc. But it's definitely no showstopper

@nhp
Copy link
Collaborator

nhp commented Sep 19, 2019

Shouldn't there be at least some kind of possibility to then add custom attributes to the cast maps? Or is this then left to the user to override?

@cewald
Copy link

cewald commented Nov 14, 2019

Is there work in progress?
I ran into this problem with german postcodes which could contain a leading zero.
It obviously won't work without a specific mapping.

@cewald
Copy link

cewald commented Nov 14, 2019

Shouldn't there be at least some kind of possibility to then add custom attributes to the cast maps? Or is this then left to the user to override?

You could easily use the Magento module system to overwrite a mapper classes you need to extend.

@cewald
Copy link

cewald commented Nov 14, 2019

@sandermangel @nhp I added an updated version of this PR (#49) with an approach to extend the mapping without class overwrites. It works like in the DivanteLtd/magento1-vsbridge-indexer and its custom data-sources.

@afirlejczyk afirlejczyk removed their request for review November 14, 2019 22:03
@mtarld mtarld closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema invalid: Invalid value types
5 participants