Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema invalid: Invalid value types #24

Open
mtarld opened this issue Mar 14, 2019 · 0 comments
Open

Schema invalid: Invalid value types #24

mtarld opened this issue Mar 14, 2019 · 0 comments

Comments

@mtarld
Copy link
Contributor

mtarld commented Mar 14, 2019

In Magento1 vsBridge, json response is created using json_encode with JSON_NUMERIC_CHECK flag.

Therefore, every string that look like integer is casted as integer.
That's a good thing, but that creates some bugs:

  • Fields such as telephone, postcode, ... must be strings according to vsf schema. That's why vsf doesn't validate data.
  • Numbers like '06467' will always be returned as '6467'
  • cart id is returned as integer but should be string (then order cannot be placed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant