Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share contacts and groups with other users #423

Closed
mikeallbutt opened this issue Aug 22, 2020 · 5 comments
Closed

Share contacts and groups with other users #423

mikeallbutt opened this issue Aug 22, 2020 · 5 comments
Assignees
Labels
feature New feature or request
Milestone

Comments

@mikeallbutt
Copy link
Collaborator

mikeallbutt commented Aug 22, 2020

Like what is available on the website, it will be necessary for some app users to be able to share a record with another user of the instance. This could be done by having a share button in the FAB of a contact or group.

@zdmc23 zdmc23 added the feature New feature or request label Aug 26, 2020
@zdmc23 zdmc23 added this to the Post-MVP milestone Aug 26, 2020
@zdmc23 zdmc23 modified the milestones: Post-MVP, Sprint 28 Sep 18, 2020
@ericchen59 ericchen59 added the specs needed Need greater detail/specification before starting development label Oct 5, 2020
@ahillbilly
Copy link

In the top right corner of a contact or group detail record is a share icon with the word "Share" after it. Clicking this opens a modal to display which users the contact record is currently shared with and also allows the current user to add or remove other users from this list.

Currently, a mobile app user is not able to share a record, but needs the ability to do so.

Screen Shot 2020-10-06 at 11 57 42 AM

@raschdiaz please share what information is needed for clarity here.

@raschdiaz-zz
Copy link
Contributor

raschdiaz-zz commented Oct 6, 2020

Hi @ahillbilly, an example of web behavior flow would be helpful. About visual behavior, we consider something like this:

A new option in the FAB, called 'Share'. When the user press this button, a modal will be displayed with a field to edit the users / contacts to share this contact / group.

This is correct?

@ahillbilly
Copy link

Before starting work on this, I'd like to get group consensus on the UI placement. The FAB could work, but it doesn't feel like the right place in context of the other quick actions...

Let's hold on this and try to get additional feedback.

The use case though is that I am working with a contact and I know that I will be traveling for a month and my friend or co-worker is going to stay and is willing to connect with the contact, except that he doesn't have access to the contact record and details. So I will click on the share button, it will open a modal that shows (like all connection fields) the users that currently have access to the contact's record. I'll click in the field to add my co-worker's user name and the type-ahead will show me the list of names available to connect. I select my co-workers name from the list and it adds his user to the list of contacts that the record is shared with and on the server side he is granted access (shared) the specific contact record... as if he was assigned, sub-assigned or @mentioned in a comment. The sharing of permissions is the same for all these forms.

@ericchen59 ericchen59 self-assigned this Oct 9, 2020
@ericchen59
Copy link

User Story
As a user, I want to be able to share a record so that another user can view, edit, and comment on the contact's record.

Acceptance Criteria

  • Access a share option from a hamburger menu in the upper right corner, to the right of the Edit button
  • user can share and unshare with any other user

Web version share button (so you can check flow on web version)
Screen Shot 2020-10-08 at 12 02 33 PM

hamburger icon (in white below)
hamburger

Example what the Kebab menu can look like
Kebab menu

@raschdiaz - let me know if you have additional questions

@ericchen59 ericchen59 removed the specs needed Need greater detail/specification before starting development label Oct 13, 2020
@ericchen59 ericchen59 modified the milestones: 4 Sprint 28, 2 Backlog Confirmed, 3 Ready, 5 Sprint 29 Oct 13, 2020
@ericchen59 ericchen59 added the TDM label Oct 18, 2020
@raschdiaz-zz raschdiaz-zz mentioned this issue Oct 24, 2020
@raschdiaz-zz
Copy link
Contributor

raschdiaz-zz commented Oct 24, 2020

Hi @mikeallbutt @zdmc23 @ahillbilly @ericchen59 see the following video showing the implementation:

https://drive.google.com/file/d/1rn74q3L3SjKUm0o7ylSDQQ1mmk31d4Ai/view?usp=sharing

Several translations were added, please add the remaining values of translations.

@zdmc23 zdmc23 closed this as completed in 33aedeb Oct 27, 2020
zdmc23 added a commit that referenced this issue Jan 27, 2021
* upgrade to Expo 39

* bump to v1.9

* make updates per new Notifications API: https://docs.expo.io/versions/latest/sdk/notifications/

* Hotfix to resolve issue where native-base "<Content>" component was causing a blank Settings Screen

ActivityIndicator was not being displayed on some Android devices due to blending gray spinner into gray background; switch to Colors.tintColor resolves the issue

* bump back to v1.9 after 1.8.1 hotfix

* Sprint 29 (#482)

* Resolves #423

* Resolves #350

* Resolves #425

* Sprint 29 (#487)

* Resolves #458

* Sprint 29 (#488)

* Resolves #420

* Sprint 30 (#489)

* Resolves #468

* Sprint 30 (#490)

* Resolves #484

* Sprint 30 (#492)

* Resolves #169

* Sprint 30 (#493)

* Resolves #357

* Resolves #474

* Sprint 30 (#494)

* Resolves #474

* Sprint 31 (#498)

* Resolves #491

* Resolves #497

* Sprint 31 (#499)

* Resolves #497

* Sprint 31 (#511)

* Resolves #495

* Resolves #512 - Test Automation IDs for Login workflow

* Sprint 31 (#513)

* Resolves #353

* update language schema to pass CI unit tests

* Sprint 31 (#519)

* Resolves #360

* Sprint 32 (#520)

* Resolves #430

* Sprint 32 (#524)

* Resolves #358

* Sprint 32 (#525)

* Resolves #508

* Sprint 32 (#529)

* Resolves #528

* Resolves #509

* Sprint 32 (#533)

* Resolves #410

* Sprint 33 (#534)

* Resolves #532

* Sprint 33 (#535)

* Resolves #532

* Sprint 33 (#536)

* Resolves #514

* Sprint 33 (#538)

* Resolves #516

* Sprint 34 (#542)

* Resolves #539

* Bump immer from 7.0.14 to 8.0.1 (#541)

Bumps [immer](https://github.com/immerjs/immer) from 7.0.14 to 8.0.1.
- [Release notes](https://github.com/immerjs/immer/releases)
- [Commits](immerjs/immer@v7.0.14...v8.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Hans Smüller Rasch Diaz <raschdiaz@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants