Skip to content
This repository has been archived by the owner on May 28, 2021. It is now read-only.

Adding ShowTaskbarSearchBox #55

Closed
wants to merge 2 commits into from
Closed

Conversation

Letouane
Copy link

@Letouane Letouane commented Jan 15, 2018

Initial functions permited only to : hide/show Cortana from the taskbar.
Now defining explicitely how to display Cortana.

(error on the last upload : used my personnal preset)
(firts commit ever, be kind please)

Initial functions permited only to : hide/show Cortana from the taskbar.
Now defining explicitely how to display Cortana.
Adding ShowTaskbarSearchIcon and adapting ShowTaskbarSearchBox
@Disassembler0
Copy link
Owner

Although there is nothing wrong with the tweak itself, there are few points for why I choose not to merge the PR.

The original HideTaskbarSearchBox tweak is aimed to get rid of the control altogether. I see the taskbar element as utterly pointless, because if you want to search for something, since Windows 7 you simply press the ⊞ Win key and start typing. The ShowTaskbarSearchBox counterpart exists only because I aim to offer reverse functions for all the tweaks and it simply reverts the setting to the default value. Originally, on pre-RTM versions, the default was search box, since RTM onwards, the default changed to icon, so yeah, the functions should probably be renamed to reflect the actual behaviour. Moreover, offering multiple choices beyond simple do that - undo that pair is something what I'd like to generally avoid. Although it's possible that in future, some tweak where this would be necessary will come up, in which case I'm gonna revisit your proposal.

Thanks anyway.

kevinbushman added a commit to kevinbushman/Win10-Initial-Setup-Script that referenced this pull request Jul 1, 2018
* Remove the test preset + move the default preset one level up

* Update "DisableSmartScreen" to use GPO

* Update "Disable Web Search" for 1803

* Update "DisableAppSuggestions" to remove ads from Task View

* Merge "DisableLockScreenSpotlight" into "DisableAppSuggestions"

* Add "DisableActivityHistory"

* Update "Disable Location Tracking" for 1803

* Slim down "SetP2PUpdateLocal" and comment from default preset

* Remove "DisableAutoLogger" as it was never useful

* Add "DisableSMBServer", closes Disassembler0#65 (thx @Phenix66)

* Update "DisableFeedback" to use GPO
(1507 don't have the GPO, so the HKCU stays)

* Move "DisableTailoredExperiences" to separate tweak and use GPO

* Update "DisableAdvertisingID" to use GPO

* Add "Disable LLMNR"

* Add "Enable Core Isolation Memory Integrity"

* Update "DisableUpdateDriver" to use GPO and set more keys

* Comment "DisableHomeGroups" as they were removed in 1803

* Update "DisableSharedExperiences" to use GPO

* Add note to "DisableLockScreenRS1"

* Update "DisableAdobeFlash" to use GPO

* Save a few characters by converting hex sequences to decimal

* Shave off some wait time from "UninstallOneDrive"

* Update "InstallLinuxSubsystem" compatibility with old OS builds

* Update "UnpinStartMenuTiles" for 1803, closes Disassembler0#71 (thx @sippi90)

* Update "UninstallInternetExplorer" to support also x86, related to Disassembler0#62

* Add more bloatware for removal and sort alphabetically, closes Disassembler0#76, closes Disassembler0#77 (thx @jnslmk and @agsimmons)

* Update backwards compatibility of "DisableDefender"

* Optimize "ShowTaskManagerDetails" and add a note

* Suppress XboxIdentityProvider error on pre-1607 builds

* Few more build restrictions and notes

* Update "SetControlPanel*" to add icon size choice
Also set them per-user and don't trigger antimalware

* Update "ShowTaskbarSearch*" to add type choice, reimplements Disassembler0#55 (thx @Letouane)

* Split "ShowTaskbarTitles" to add type choice, closes Disassembler0#78 (thx @sztanpet)

* Update README.md into mini-wiki

* v2.20, 2018-04-15 - RS4 (1803) ready
Lots of changes, few of them BREAKING, hence the bigger version bump.
 - Add "DisableActivityHistory"
 - Add "DisableSMBServer" (thx @Phenix66)
 - Add "Disable LLMNR"
 - Add "Enable Core Isolation Memory Integrity"
 - Add more bloatware for removal (thx @jnslmk and @agsimmons)
 - Update "UnpinStartMenuTiles" for 1803 (thx @sippi90)
 - Update "Disable Web Search" for 1803
 - Update "Disable Location Tracking" for 1803
 - Update "DisableAppSuggestions" to remove ads from Task View
 - *BREAKING* Update "ShowTaskbarSearch*" to add type choice (thx @Letouane)
 - *BREAKING* Split "ShowTaskbarTitles" to add type choice (thx @sztanpet)
 - *BREAKING* Update "SetControlPanel*" to add icon size choice
 - Update "DisableSmartScreen" to use GPO
 - Update "DisableFeedback" to use GPO
 - Update "DisableAdvertisingID" to use GPO
 - Update "DisableSharedExperiences" to use GPO
 - Update "DisableAdobeFlash" to use GPO
 - Update "DisableUpdateDriver" to use GPO and set more keys
 - Move "DisableTailoredExperiences" to separate tweak and use GPO
 - Update "UninstallInternetExplorer" to support also x86
 - Update "InstallLinuxSubsystem" compatibility with old OS builds
 - Update "DisableDefender" compatibility with old OS builds
 - Update "DisableXboxFeatures" compatibility with old OS builds
 - Update "SetP2PUpdateLocal" and comment from default preset
 - Comment "DisableHomeGroups" removed in 1803
 - *BREAKING* Merge "DisableLockScreenSpotlight" into "DisableAppSuggestions"
 - *BREAKING* Remove "DisableAutoLogger" as it was never useful
 - Remove test files as they seemed to be confusing
 - Few other minor improvements
 - Documentation update

* Remove prompt when stopping OneDrive service (Disassembler0#82)

* Fix newlines in the default preset and rename bat to cmd, related to Disassembler0#85

* Fix a typo in comment, closes Disassembler0#88

* Add Lenovo AppxPackage bloatware (Disassembler0#89)

* Set taskbar buttons combination modes for multi-monitor setups. (Disassembler0#91)

* Update "DisableTelemetry" to disallow build previews, closes Disassembler0#92 (thx @T4CC)

* Update RS4 build info

* Add FAQ about GPO effects, closes Disassembler0#84

* Add "Hide Account Protection warning"

* Split DisableThumbsDB (Disassembler0#95), closes Disassembler0#85

* Add DisableWebLangList, enhance DisableAppSuggestions (Disassembler0#90)

* Add "Disable Edge desktop shortcut creation"

* Added option to show/hide checkboxes next to items in explorer (Disassembler0#97)

* Update EnableMeltdownCompatFlag note, closes Disassembler0#98 (thx @Zero3)

* Use absolute paths in Default.cmd file (Disassembler0#104)

* Add "Uninstall Windows Fax and Scan Services" (Disassembler0#103)

* Fix forgotten rename, closes Disassembler0#105
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants