Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: CellOccupancyMatrix::is_area_in_range() now immutable #516

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Minor: CellOccupancyMatrix::is_area_in_range() now immutable #516

merged 1 commit into from
Jul 19, 2023

Conversation

inobelar
Copy link
Contributor

Objective

Why did you make this PR?

I found, that CellOccupancyMatrix::is_area_in_range(...) is immutable, but its not declared. For clarity in this PR removed mut near self.

@alice-i-cecile alice-i-cecile added the code quality Make the code cleaner or prettier. label Jul 19, 2023
@alice-i-cecile
Copy link
Collaborator

Hmm, I don't think this is breaking. It changes a public API, but all existing code should still work.

@nicoburns
Copy link
Collaborator

I don't think this function is actually public. It's a method on a pub(crate) type.

@nicoburns nicoburns merged commit 6cf7960 into DioxusLabs:main Jul 19, 2023
16 checks passed
@inobelar inobelar deleted the patch-2 branch July 19, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
code quality Make the code cleaner or prettier.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inobelar @alice-i-cecile @nicoburns