Minor: changed docs for Layout::location (bottom-left -> top-left) & added test #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode size to 100% to fully fill parent
|
I'm not entirely convinced the test is useful, but the documentation fix certainly is. Merging as-is, and we can always remove the test at a later date if want to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I found a discrepancy between documentation and code behavior. As I can see (after playing with
Style::padding),Layout::locationrepresentstop-leftpoint of the node rect, notbottom-left.Also I added test for it. I don't know where to add it, so I added it into
src/tree/taffy_tree/tree.rs