Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove serde renames from Display #153

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

jshrake
Copy link
Contributor

@jshrake jshrake commented Jun 11, 2022

Objective

This PR removes the rename serde field attribute from the Display variants so that the serialized and deserialized values are consistent with the other style enum variants.

@alice-i-cecile alice-i-cecile added usability Make the library more comfortable to use code quality Make the code cleaner or prettier. labels Jun 11, 2022
Copy link
Collaborator

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with this. I don't see any good reason to keep this inconsistency around.

@alice-i-cecile
Copy link
Collaborator

#155 is already very broken, so I'm going to merge this in.

@alice-i-cecile alice-i-cecile merged commit a5f9a8b into DioxusLabs:main Jun 11, 2022
@jshrake jshrake deleted the serde-consistency branch June 11, 2022 18:36
jkelleyrtp pushed a commit that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Make the code cleaner or prettier. usability Make the library more comfortable to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants