Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with accessing "weighted_centroid" attribute #918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmarUCLA
Copy link

The new scikit-image version now uses the attribute name "centroid_weighted" instead of "weighted_centroid". In addition to this, there were bugs with accesses the attribute as prop.centroid_weighted, so now changed it to accessing the attribute as prop['centroid_weighted']

The new scikit-image version now uses the attribute name "centroid_weighted" instead of "weighted_centroid". In addition to this, there were bugs with accesses the attribute as prop.centroid_weighted, so now changed it to accessing the attribute as prop['centroid_weighted']
@manthey
Copy link
Contributor

manthey commented Dec 8, 2021

With scikit-image 0.19, the code with "weighted_centroid" is still allowed. With this change, we need some code to handle either case (so the library still works as long as we support Python 3.6, since the last scikit-image version that works on 3.6 is 0.17).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants