Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #217 #224

Merged
merged 1 commit into from
Apr 4, 2018
Merged

fix issue #217 #224

merged 1 commit into from
Apr 4, 2018

Conversation

Rushi98
Copy link
Member

@Rushi98 Rushi98 commented Apr 3, 2018

fixes #217
All Firebase retrievals are send to background services

Firebase syncing will be done in background services
for MainActivity, HomeFragment
via MaintenanceService, HomeService
@kukreja-vikramaditya kukreja-vikramaditya merged commit 35f9a0c into Devsoc-BPGC:chat Apr 4, 2018
@kukreja-vikramaditya
Copy link
Contributor

Merged.

Changes ->

  • Got rid of complicated backstack method. only home items will be used for backstack
  • Fix change listener bugs in adapters
  • Fix bug in checkJobStatus not being called on cancel
  • Reduction in layout complexity in home

Things to remove

  • addToBackStack ot required now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants