Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace remaining uses of winapi with windows_sys #226

Merged
merged 2 commits into from
Mar 31, 2024
Merged

refactor: replace remaining uses of winapi with windows_sys #226

merged 2 commits into from
Mar 31, 2024

Conversation

ekse
Copy link
Contributor

@ekse ekse commented Mar 31, 2024

This replaces the remaining uses of winapi as per #174.

I ran the tests with the features scard,tsssp enabled since some of the replaced calls are behind these features.

CBenoit
CBenoit approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! It was less changes than I expected, nice.

@CBenoit CBenoit changed the title chore: replace remaining uses of winapi with windows_sys refactor: replace remaining uses of winapi with windows_sys Mar 31, 2024
@CBenoit CBenoit merged commit ec70646 into Devolutions:master Mar 31, 2024
40 checks passed
@ekse ekse deleted the replace-winapi branch March 31, 2024 15:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekse @CBenoit