Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Boolean handling and debug statement #39

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented Mar 25, 2024

Handling all Actions YAML inputs as strings seems quite brittle. Using getBooleanInput instead of plain old string-returning getInput seems like a wise move whenever true Booleans are in question.

I've also added a debugging statement for the full command being run to start the server.

@colemickens
Copy link
Member

There's also ACTIONS_STEP_DEBUG which should enable core.isDebug which should get you a bit extra spew.

@lucperkins lucperkins merged commit e734a0a into main Mar 25, 2024
4 checks passed
@lucperkins lucperkins deleted the handle-boolean-values branch March 25, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants