Verify etag hashes on download / cache hit #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for detsys-ts-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cole-h
reviewed
Sep 5, 2024
src/s3-md5.ts
Outdated
| actionsCore.info( | ||
| `Verifying etag failed: etag mismatch. Wanted ${expectedEtag}, got ${actualEtag}`, | ||
| ); | ||
| return "corrupt"; |
There was a problem hiding this comment.
I'm not a huge fan of returning strings that we need to compare against... can we rename this to isEtagValid and have it instead return a boolean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've heard a report that a user seems to have a plausibly corrupt nix installer in the cache. This change checks the downloaded file and the file from the cache.
Checklist