Fix install scripts to remove temp directories #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Linux standards, the /var/tmp directory should be preserved across reboots and should not be deleted frequently by the OS, and many Linux distributions never delete files from /var/tmp. Installers and programs that use /var/tmp are supposed to clean up after themselves and delete the temporary directories they create in /var/tmp. Since our install scripts do not clean up after themselves, the Fractus nodes suffer from an ever-growing number of temporary directories in /var/tmp (each containing copies of libfabric, nlohmann_json, and mutils) that are not deleted automatically. (See https://superuser.com/questions/168125, https://superuser.com/questions/499039/, and https://unix.stackexchange.com/questions/698677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Linux standards, the /var/tmp directory should be preserved across reboots and should not be deleted frequently by the OS, and many Linux distributions never delete files from /var/tmp. Installers and programs that use /var/tmp are supposed to clean up after themselves and delete the temporary directories they create in /var/tmp. Since our install scripts do not clean up after themselves, the Fractus nodes suffer from an ever-growing number of temporary directories in /var/tmp (each containing copies of libfabric, nlohmann_json, and mutils) that are not deleted automatically.
(See https://superuser.com/questions/168125, https://superuser.com/questions/499039/, and https://unix.stackexchange.com/questions/698677)