Persistent get delta #173
Merged
Persistent get delta #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the T in Persistent<T> implements IDeltaSupport interface, Persistent<T>::get() will reconstruct the states by applying the delta from the first log entry to a given version. This is a heavy operation. However, many applications may just want the delta value instead of the reconstructed state. Persistent<T>::getDelta... calls allows the application to retreive this delta value only.
The default behavior of Persistent<T>::get(ver) will return the state of T at version 'ver'. If there is no log exists for 'ver', its latest state before version 'ver' will be returned, which represents the state of the object at a virtual virtual 'ver'. However, although Persistent<T>::getDelta(ver) share a lot of logic with Persistent<T>::get(ver), it has a different semantic: it needs to return the delta at exact 'ver', which does not exists in the given example. This patch introduced a boolean 'exact' flag in the parameter list of PersistLog::getEntry() and PersistLog::getVersionIndex(), so that the Persistent<T>::getDelta(ver) will throw an exception on an invalid version by enforcing the flag.
|
I want to merge the pull request I made about 10 days ago. This feature is required for efficient Cascade LINQ API. I verified with regression test that this update will not change the performance of core derecho performance. Please let me know if you guys agree this merge. @sagarjha @mpmilano @etremel |
|
Yes, this looks good to me. |
|
Thanks, Edward! I guess should merge it this weekend if there is no more feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature:
Improvements and bugfixes: